Skip to content

Conversation

@hmk114
Copy link
Contributor

@hmk114 hmk114 commented Mar 30, 2025

This is a fix similar to #194.

@arntanguy
Copy link

Thanks. Additionally the latest release 0.11 does not come with checksum files.
I have commented out the checksum check locally to make it work.

@charging1948
Copy link

The latest release does come with a shasum.txt. We need to filter out the specific arch, then we have access to the shasum.

@hmk114
Copy link
Contributor Author

hmk114 commented Apr 3, 2025

Thanks for your notice! I've added checksum handling logic in download script.

@mclean-connor
Copy link

can we get this merged?

@DeevsDeevs
Copy link

hey, any reasons or blockers why this can't be merged?

@noprobelm
Copy link

I'm also in need of this merge.

@lycheeje11y
Copy link

Me too! I am using the VScode SSH extension for now...

@lekhanhtoan37
Copy link

   Installing Neovim (if required)
    Command: chmod +x /home/ubuntu/.remote-nvim/scripts/neovim_download.sh && chmod +x /home/ubuntu/.remote-nvim/scripts/neovim_utils.sh && chmod +x /home/ubuntu/.remote-nvim/scripts/neovim_install.sh && /home/ubuntu/.remote-nvim/scripts/neovim_install.sh -v v0.11.1 -d /home/ubuntu/.remote-nvim -m binary -a x86_64

    Downloading Neovim...
    dnslookup: 0.000796 | connect: 0.024990 | appconnect: 0.072770 | pretransfer: 0.072835 | starttransfer: 0.246174 | total: 0.246226 | size: 0
    curl: (22) The requested URL returned error: 404

nvim 0.11 and still met this issue

@amitds1997 amitds1997 requested a review from Copilot May 31, 2025 17:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the release naming for newer versions of Neovim on Linux by appending an architecture suffix to the release filenames. Key changes include:

  • Updating test cases for both macOS and Linux to expect the new “x86_64” suffix.
  • Adjusting the provider and download logic to construct filenames with the architecture.
  • Revising the Lua utility function to generate release names for stable and nightly versions consistently.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/remote-nvim/providers/utils_spec.lua Updated tests to expect architecture suffixes in offline release names.
tests/remote-nvim/providers/provider_spec.lua Modified expected release path to include architecture information.
scripts/neovim_download.sh Added a new -a parameter and updated URL construction and checksum handling.
lua/remote-nvim/providers/utils.lua Changed release name generation logic to include the architecture for certain versions.

@twstagg
Copy link

twstagg commented Jun 19, 2025

While it seems nice, the thought of this being merged...

For the time being, you can just modify your LazySpec to look like this if you would like to make use of the changes in the meantime. This worked like a charm for me:

return {
  {
    "hmk114/remote-nvim.nvim",
    version = "*", -- Pin to GitHub releases
    dependencies = {
      "nvim-lua/plenary.nvim", -- For standard functions
      "MunifTanjim/nui.nvim", -- To build the plugin UI
      "nvim-telescope/telescope.nvim", -- For picking b/w different remote methods
    },
    config = true,
  },
}

@amitds1997 amitds1997 merged commit 9a23aff into amitds1997:main Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants