-
Notifications
You must be signed in to change notification settings - Fork 56
Fix release name for newer versions of neovim on Linux #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks. Additionally the latest release 0.11 does not come with checksum files. |
|
The latest release does come with a |
|
Thanks for your notice! I've added checksum handling logic in download script. |
|
can we get this merged? |
|
hey, any reasons or blockers why this can't be merged? |
|
I'm also in need of this merge. |
|
Me too! I am using the VScode SSH extension for now... |
nvim 0.11 and still met this issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the release naming for newer versions of Neovim on Linux by appending an architecture suffix to the release filenames. Key changes include:
- Updating test cases for both macOS and Linux to expect the new “x86_64” suffix.
- Adjusting the provider and download logic to construct filenames with the architecture.
- Revising the Lua utility function to generate release names for stable and nightly versions consistently.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/remote-nvim/providers/utils_spec.lua | Updated tests to expect architecture suffixes in offline release names. |
| tests/remote-nvim/providers/provider_spec.lua | Modified expected release path to include architecture information. |
| scripts/neovim_download.sh | Added a new -a parameter and updated URL construction and checksum handling. |
| lua/remote-nvim/providers/utils.lua | Changed release name generation logic to include the architecture for certain versions. |
|
While it seems nice, the thought of this being merged... For the time being, you can just modify your LazySpec to look like this if you would like to make use of the changes in the meantime. This worked like a charm for me: |
This is a fix similar to #194.