Closed
Conversation
Contributor
Author
|
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题背景
在
setCurrentTime的热行更新逻辑中,BG 行会被默认与主行绑定激活/失活。这导致即使下游显式配置
syncMainAndBackgroundLines: false,BG 行仍可能跟随主行状态变化,而不是严格按自身时间轴工作。根因
setCurrentTime中多处主行与 BG 行联动逻辑未受syncMainAndBackgroundLines开关控制:修复内容
文件:
packages/core/src/lyric-player/base.tsconst syncMainAndBackgroundLines = this.optimizeOptions.syncMainAndBackgroundLines !== falsecontinue;startTime/endTime独立激活,不再依赖主行联动。影响范围
true时仍保持主行-BG 联动)。syncMainAndBackgroundLines: false时生效:验证
pnpm -C packages/core build