HOTFIX: remove mc2nu mapping inside loss cone updater on CPU#973
Open
Maxwell-Rosen wants to merge 1 commit intomainfrom
Open
HOTFIX: remove mc2nu mapping inside loss cone updater on CPU#973Maxwell-Rosen wants to merge 1 commit intomainfrom
Maxwell-Rosen wants to merge 1 commit intomainfrom
Conversation
…physical coordinates. This is wrong in space, but okay in velocity, because the magnetic field maximum is found in computaitonal coordinates, so it should be compared against computational coordinates. Code compiles. This isn't the cleanest version, but I will clean it up more in the gk-oap-2x-tandem-kinetic branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The c2p here should not be there. The c2p is used to convert xn into physical coordinates. This is wrong in space, but okay in velocity, because the magnetic field maximum is found in computational coordinates, so it should be compared against computational coordinates. Code compiles. This isn't the cleanest version, but I will clean it up more in the gk-oap-2x-tandem-kinetic branch.
Code compiles on linux CPU laptop
The location of maximum B is computed here. Note that there is a log_to_comp, but there is no mc2nu function or non-uniform mapping.
