Conversation
…efore-other-statements chore: windows error before other imports for nicer error message
Python 3.14 removes the implicit creation of an event loop when running asyncio.get_event_loop(). Rather than manually managing the loop creation, switch the async tests to use the higher level asyncio.run() interface, as recommended by the standard library docs. https://docs.python.org/dev/whatsnew/3.14.html#id4 Resolves #741
Avoid manual async loop management
If _return_cmd is True, have __await__ return the RunningCommand object rather than a string representation. Fixes #743 Add test for this behavior and adjust existing tests because the baked test python instance is created with _return_cmd True.
await command with _return_cmd True returns RunningCommand
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.