Fix boolean bake override not working#770
Open
bysiber wants to merge 1 commit intoamoffat:developfrom
Open
Conversation
When overriding a baked boolean True argument with False (e.g. ls.bake(a=True)(a=False)), the False value was silently dropped by compile_args while the baked True flag remained, so the override had no effect. Now both bake() and __call__() filter out previously baked flags that are being explicitly overridden with False.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a boolean argument is baked as
True(e.g.ls.bake(a=True)), calling witha=Falseshould override it and drop the flag. Currently theFalsevalue is silently discarded bycompile_argswhile the baked-aflag remains in the argument list, so the override has no effect.This fixes it by filtering out previously baked flags when a
Falseoverride is passed, both inbake()(for chained bakes) and__call__()(for call-time overrides).Fixes #753