fix: github ref randomly empty for release triggers#277
fix: github ref randomly empty for release triggers#277amondnet merged 2 commits intoamondnet:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @vedxyz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've addressed an issue where the GitHub ref was occasionally empty when a workflow was triggered by a release event. This fix ensures that the ref is always correctly populated for release triggers by explicitly constructing it from the release's tag name, thereby preventing deployment failures and improving the reliability of release-based workflows.
Highlights
- Bug Fix for Release Triggers: This pull request addresses a critical bug where the
github refcould be unexpectedly empty for workflows triggered byreleaseevents, leading to failures in subsequent deployment steps. - Explicit Ref Construction: To resolve the
refemptiness, I've implemented a workaround that explicitly constructs therefforreleaseevents by combiningrefs/tags/with thetag_namefrom the release payload, ensuring therefis always correctly populated.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Deploy preview for team-scope-test ready! ✅ Preview Built with commit 083b1ed. |
|
Deploy preview for express-basic-auth ready! ✅ Preview Built with commit 083b1ed. |
There was a problem hiding this comment.
Code Review
This pull request fixes an issue where the GitHub ref is sometimes empty for release triggers by manually constructing the ref from the release tag name. The change is correct and addresses the problem described. I've added one suggestion to make the code more robust by checking for the existence of tag_name in the payload before using it.
amondnet
force-pushed
the
release-ref-fix
branch
from
9b5da51 to
083b1ed
Compare
|
2 participants
Fixes #46
I believe the cause for the above bug is actions/runner#2788. The workaround to the runner bug is to create the ref yourself by prefixing the tag name with
refs/tags/(See sources 1, 2, 3).