Skip to content

style: remove prettier and migrate to antfu eslint config#283

Merged
amondnet merged 1 commit intomasterfrom
280-remove-prettier-and-migrate-to-antfueslint-config
Aug 28, 2025
Merged

style: remove prettier and migrate to antfu eslint config#283
amondnet merged 1 commit intomasterfrom
280-remove-prettier-and-migrate-to-antfueslint-config

Conversation

@amondnet
Copy link
Copy Markdown
Owner

No description provided.

@amondnet amondnet linked an issue Aug 28, 2025 that may be closed by this pull request
12 tasks
@amondnet amondnet self-assigned this Aug 28, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @amondnet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant internal refactoring of the project's development environment by overhauling its code style and linting practices. The primary goal is to streamline the codebase by removing the separate Prettier formatter and consolidating all style enforcement under a new, unified ESLint configuration based on @antfu/eslint-config. This change aims to simplify the development workflow, reduce potential conflicts between formatting tools, and ensure consistent code quality moving forward. Additionally, it includes minor code adjustments to conform to the new style rules, updates to project dependencies, and foundational changes to the testing setup.

Highlights

  • Code Style and Linting Overhaul: This pull request completely revamps the project's code formatting and linting setup by removing Prettier and migrating to the @antfu/eslint-config.
  • Configuration File Changes: The old .eslintrc.json and .prettierrc.json files have been removed, replaced by a new eslint.config.mjs that leverages the Antfu configuration, including specific stylistic rules and rule overrides.
  • Dependency Updates: The package.json has been updated to reflect the new tooling, removing Prettier-related dependencies and adding @antfu/eslint-config, alongside an upgrade to ESLint v9.
  • Codebase Refactoring: Minor code adjustments in index.js and now.js reflect the new linting rules, including updates to require paths and regex patterns.
  • Testing Infrastructure: A basic Jest test setup has been introduced with jest.config.js and a placeholder test in index.test.js, laying groundwork for future testing.
  • Documentation and Metadata Updates: Various documentation files (README.md, DEVELOP.md, CLAUDE.md, action.yml, changelog_archived.md) received minor whitespace and formatting cleanups.
  • Internal Tooling Configuration: A new .claude/settings.json file was added, defining permissions for the Claude AI to interact with GitHub pull request data.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
5 Security Hotspots

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown
Contributor

Deploy preview for team-scope-test ready!

✅ Preview
https://team-scope-test-j9nfo2s1z-dietfriends.vercel.app

Built with commit 2803b83.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link
Copy Markdown
Contributor

Deploy preview for express-basic-auth ready!

✅ Preview
https://express-basic-auth-m79pgth2j-minsu-lees-projects-b1e388b7.vercel.app

Built with commit 2803b83.
This pull request is being automatically deployed with vercel-action

@amondnet amondnet merged commit 0babe7e into master Aug 28, 2025
6 of 14 checks passed
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Prettier and migrate to @antfu/eslint-config

1 participant