Open
Conversation
* fix mongoid detecting bug * fix bug on rails 6 On rails 6, if change password, in `before_save` callback - `saved_change_to_attribute?(:encrypted_password)` return false - `encrypted_password_changed?` return true
* Fix URI.unescape warning * Fix Using the last argument as keyword parameters warning
Usage of the safe operator was introduced in ruby 2.3 and new code uses that
Removed an extra bracket `]` from "configure_permitted_parameters" method.
* Fix the doc missing configure devise I had to add ```ruby # config/initializers/devise.rb Devise.setup do |config| config.mailer_sender = "example@example.com" end ``` In order to make my app send emails successfully * Fix too much newline
* wrap creation and save of token in a transaction this will reload the record and lock the row in the DB so we only ever have one request accessing the record at one time. this prevents multiple requests overwriting the tokens. * extract to method and check if #with_lock is available Co-authored-by: Pascal Betz <pascal@yova.ch>
Migrate to GitHub Actions
* Sets authorization header name * Writes and reads Authorization token * On decoding bearer token, if it is an invalid base64, rescues to empty hash * Added controller tests for Authorization header
found two double quote
* Fixed vulnerabilities * Missing plural.
* refactor: 💡 safe_email -> email NOTE: Faker::Internet.safe_email is deprecated; use email instead. It will be removed on or after 2023-10. * test: 💍 MiniTest->Minitest
Since factory bot doesn't support it anymore thoughtbot/factory_bot#1614
Updates the requirements on [sqlite3](https://github.com/sparklemotion/sqlite3-ruby) to permit the latest version. - [Release notes](https://github.com/sparklemotion/sqlite3-ruby/releases) - [Changelog](https://github.com/sparklemotion/sqlite3-ruby/blob/main/CHANGELOG.md) - [Commits](sparklemotion/sqlite3-ruby@v1.4.0...v2.0.1) --- updated-dependencies: - dependency-name: sqlite3 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Deleted dead links
…rd_token in the redirect URL. (#1650)
…tection (#1654) * fix: Update method names to devise_will_save_change_to_email? * fix: Remove email_changed? method
* Handle expired reset_password_tokens on update * fixup! Handle expired reset_password_tokens on update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.