Skip to content

Issue #74#63

Merged
ashiven merged 11 commits intomainfrom
Issue-#74
Jul 15, 2025
Merged

Issue #74#63
ashiven merged 11 commits intomainfrom
Issue-#74

Conversation

@SirGankalot
Copy link

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature

What is the current behavior? (You can also link to an open issue here)
Some notifications but not all

What is the new behavior (if this is a feature change)? If possible add a screenshot.
The update start, finish and failure will be notified to the user via a notification

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

Signed-off-by: SirGankalot <73303677+SirGankalot@users.noreply.github.com>
Signed-off-by: SirGankalot <73303677+SirGankalot@users.noreply.github.com>
@SirGankalot SirGankalot self-assigned this Jul 7, 2025
Signed-off-by: SirGankalot <73303677+SirGankalot@users.noreply.github.com>
Signed-off-by: SirGankalot <73303677+SirGankalot@users.noreply.github.com>
Signed-off-by: SirGankalot <73303677+SirGankalot@users.noreply.github.com>
@SirGankalot SirGankalot marked this pull request as ready for review July 12, 2025 13:44
@SirGankalot SirGankalot requested a review from ashiven July 12, 2025 13:44
Copy link

@ashiven ashiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

udpates

Es ist leider genau das passiert was ich befürchtet hatte. Du wirst mit update messages zugespamt weil eine message für jedes update in der update queue generiert wird.

Es wäre glaube ich am besten wenn man eine message für das zuletzt gestartete update pro worker generiert und in der message noch zusätzlich sagt für welche dependency das update genau ist.

Signed-off-by: SirGankalot <73303677+SirGankalot@users.noreply.github.com>
@SirGankalot SirGankalot requested a review from ashiven July 14, 2025 13:56
Copy link

@ashiven ashiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update1 update2 update3

Ich hab es mal so getestet:

  1. Update auf einem worker gestartet
  2. Seite neu geladen
  3. Update auf neuem worker gestartet

Einerseits müsste man vom dependency type noch den richtigen namen verwenden mit worker_update.get_dependency_type_display() und vielleicht müsste man doch update_pool[-1] anzeigen da ja in den screenshots noch das alte update angezeigt wird obwohl schon ein neues gequeued wurde

@SirGankalot
Copy link
Author

SirGankalot commented Jul 14, 2025

Ja ok hatte ich ja befürchtet das es -1 wird alles klar wird geändert

Signed-off-by: SirGankalot <73303677+SirGankalot@users.noreply.github.com>
@SirGankalot SirGankalot requested a review from ashiven July 14, 2025 20:42
Signed-off-by: SirGankalot <73303677+SirGankalot@users.noreply.github.com>
Signed-off-by: SirGankalot <73303677+SirGankalot@users.noreply.github.com>
Copy link

@ashiven ashiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job 👍

@ashiven ashiven merged commit c6eb5c4 into main Jul 15, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants