FIx a bug to add missing BlackBody & Daylight Options

[davisadam10]

The Daylight and Blackbody options have been used by folks in production who reported it not working.
Needed to add handling to pass the custom temperature through to the backend
Needed to add in the code to calculate and get the illuminent for those two options

[davisadam10]

@KelSolaar thomas sir would be great if you can double check for me this is the right way to handle black body and daylight options.

[KelSolaar]

There is something quite not right about this as the UI does already some of that work (the function is actually duplicated already), we should probably consolidate this so that there is only one entry point to generate the illuminants.

def set_illuminant_datable(illuminant, CCT):
    """
    Set the *Illuminant* `DataTable` content for given illuminant name.

    Parameters
    ----------
    illuminant : str
        Existing illuminant name or *Custom*, *Daylight* or *Blackbody*.
    CCT : numeric
        Custom correlated colour temperature (CCT) used for the *Daylight* and
        *Blackbody* illuminant types.

    Returns
    -------
    tuple
        Tuple of data and columns.
    """

    logging.info(
        'Setting illuminant datatable for "%s" illuminant and "%s" CCT...',
        illuminant,
        CCT,
    )

    labels = ["Wavelength", "Irradiance"]
    ids = ["wavelength", "irradiance"]
    precision = [
        None,
        Format(precision=DATATABLE_DECIMALS, scheme=Scheme.fixed),
    ]
    columns = [
        {
            "id": ids[i],
            "name": label,
            "type": "numeric",
            "format": precision[i],
        }
        for i, label in enumerate(labels)
    ]

    if illuminant == "Custom":
        data = [
            dict(wavelength=wavelength, irradiance=None)
            for wavelength in CUSTOM_WAVELENGTHS
        ]

    else:
        if illuminant == "Daylight":
            xy = CCT_to_xy_CIE_D(CCT * 1.4388 / 1.4380)
            illuminant = sd_CIE_illuminant_D_series(xy)
        elif illuminant == "Blackbody":
            illuminant = sd_blackbody(CCT)
        else:
            illuminant = SDS_ILLUMINANTS[illuminant]

        data = [
            dict(
                wavelength=wavelength,
                irradiance=illuminant[wavelength],
            )
            for wavelength in illuminant.wavelengths
        ]

    return data, columns

Thoughts?

[davisadam10]

Hey @KelSolaar 100%

And exactly the kind of info i was looking from you!

In general there seems to be a fair amount of logic remianing in the UI which we should move either to the common helper functions, or the application itself that the UI then only has to deal with updating the display vs processing any data.

[davisadam10]

Ill try and make a stab at this change later in the week