This repository was archived by the owner on Aug 27, 2021. It is now read-only.
fixing O(too_much) bug in recursive list_subdirs#248
Open
biappi wants to merge 1 commit intoamperka:masterfrom
Open
fixing O(too_much) bug in recursive list_subdirs#248biappi wants to merge 1 commit intoamperka:masterfrom
biappi wants to merge 1 commit intoamperka:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for some reason this function was scanning subdirectories more than once, resulting in a really sub-ottimal performance.
with this patch, i was able to reduce build of the project i'm working on from:
real 1m1.629s
to:
real 0m1.923s
on some occasion i was also able to fix an:
(ino-env)Minene:ino willy$ time ino build > /dev/null
make: /bin/sh: Argument list too long
make: *** [.build/uno/src/iec_driver.d] Error 1
real 0m32.280s
user 0m16.205s
sys 0m13.660s
error.