Skip to content

Use str_increment() to fix PHP 8.5 deprecation #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kelunik merged 3 commits into from
Aug 27, 2025
Merged

Use str_increment() to fix PHP 8.5 deprecation #222

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d363a1c
Use str_increment() to fix PHP 8.5 deprecation
nicolas-grekas Aug 27, 2025
b3ec5cc
Improve UndefinedFunction suppression for psalm
kelunik Aug 27, 2025
5d941e3
Ignore str_increment in composer-require-check
kelunik Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions psalm.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@
</errorLevel>
</UndefinedClass>

<UndefinedFunction>
<errorLevel type="suppress">
<directory name="src/Worker/Internal"/>
</errorLevel>
</UndefinedFunction>

<UnsupportedPropertyReferenceUsage>
<errorLevel type="suppress">
<directory name="src"/>
Expand Down
4 changes: 3 additions & 1 deletion src/Worker/Internal/TaskSubmission.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ final class TaskSubmission extends JobPacket
public function __construct(Task $task)
{
$this->task = $task;
parent::__construct(self::$nextId++);
$id = self::$nextId;
\PHP_VERSION_ID >= 80300 ? self::$nextId = \str_increment(self::$nextId) : ++self::$nextId;
parent::__construct($id);
}

public function getTask(): Task
Expand Down
Loading