Skip to content

Re-calculate overlay position on each select & don't modify element #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Re-calculate overlay position on each select & don't modify element #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ce6170
Re-calculate overlay position on each select & don't change element a…
tyilo Mar 3, 2012
d20ac65
Fixed scrolling
tyilo Mar 3, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions ElementContainer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,34 +6,40 @@

function ElementContainer(ele) {
this.element = ele;
this.oldBorder = ele.style.border;
this.oldBgColor = ele.style.background;
this.offsets = this.getOffset();
//this.oldBorder = ele.style.border;
//this.oldBgColor = ele.style.background;
//this.offsets = this.getOffset();

this.overlay = document.createElement('div');
this.overlay.setAttribute('class','xpathElementOverlay');
this.overlay.style.left = this.offsets.left+'px';
/*this.overlay.style.left = this.offsets.left+'px';
this.overlay.style.top = this.offsets.top+'px';
this.overlay.style.width = this.element.offsetWidth+'px';
this.overlay.style.height = this.element.offsetHeight+'px';
this.overlay.style.height = this.element.offsetHeight+'px';*/
this.overlay.style.display = 'none';
document.body.appendChild(this.overlay);
}

ElementContainer.prototype.highlight = function() {
this.element.style.border = 'solid 1px black';
//this.element.style.border = 'solid 1px black';
//this.element.style.background = 'yellow';
this.overlay.style.display = 'none';
};

ElementContainer.prototype.select = function() {
this.element.style.border = 'solid 1px red';
this.offsets = this.getOffset();
this.overlay.style.left = this.offsets.left+'px';
this.overlay.style.top = this.offsets.top+'px';
this.overlay.style.width = this.element.offsetWidth+'px';
this.overlay.style.height = this.element.offsetHeight+'px';

//this.element.style.border = 'solid 1px red';
//this.element.style.background = 'red';
this.overlay.style.display = '';
};

ElementContainer.prototype.clear = function() {
this.element.style.border = this.oldBorder;
//this.element.style.border = this.oldBorder;
//this.element.style.background = this.oldBgColor;
document.body.removeChild(this.overlay);
};
Expand All @@ -43,8 +49,8 @@ ElementContainer.prototype.getOffset = function() {
var _x = 0;
var _y = 0;
while( el && !isNaN( el.offsetLeft ) && !isNaN( el.offsetTop ) ) {
_x += el.offsetLeft - el.scrollLeft;
_y += el.offsetTop - el.scrollTop;
_x += el.offsetLeft; //- el.scrollLeft;
_y += el.offsetTop; //- el.scrollTop;
el = el.offsetParent;
}
return { top: _y, left: _x };
Expand Down