Update rebase curve parameters and deviation threshold to match mainnet #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalavandhan
reviewed
Sep 10, 2024
Update rebase curve parameters and deviation threshold to match mainnet
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
aalavandhan
reviewed
Sep 10, 2024
contracts/UFragmentsPolicy.sol
Outdated
| rebaseFunctionGrowth = int256(3 * (10**DECIMALS)); | ||
| rebaseFunctionUpperPercentage = int256(10 * (10**(DECIMALS - 2))); // 0.1 | ||
| rebaseFunctionLowerPercentage = int256((-10) * int256(10**(DECIMALS - 2))); // -0.1 | ||
| rebaseFunctionGrowth = int256(45 * (10**DECIMALS)); |
There was a problem hiding this comment.
The original intent was 45, so we can keep it 45 here and update mainnet on the next proposal
aalavandhan
approved these changes
Sep 12, 2024
ahnaguib
force-pushed
the
rebase-upgrade
branch
from
352a40c to
852c7a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower:-0.077
Upper: 0.05
Growth: 45
Deviation threshold 2.5%