Skip to content

Conversation

@aalavandhan
Copy link
Member

Added cpi and exchange rate getters

@aalavandhan aalavandhan force-pushed the policy-interface-update branch from 3275adb to fe4a8c6 Compare October 9, 2024 18:31
@openzeppelin-code
Copy link

openzeppelin-code bot commented Oct 9, 2024

Policy interface update

Generated at commit: e3931381cff3948a708dbf6166ac37331ed2e610

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
1
0
5
23
30
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link
Member

@brandoniles brandoniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add getTargetRate() to the IAmpleforth interface.

But don't think we need getExchangeRate()

Copy link
Member

@brandoniles brandoniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalavandhan aalavandhan merged commit d2b6727 into master Oct 16, 2024
3 checks passed
@aalavandhan aalavandhan deleted the policy-interface-update branch October 16, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants