Skip to content

heredoc parsing: require ending delimiter to be on its own line with optional indentation#194

Merged
kkozik-amplify merged 1 commit intomainfrom
fix-heredoc
Feb 25, 2025
Merged

heredoc parsing: require ending delimiter to be on its own line with optional indentation#194
kkozik-amplify merged 1 commit intomainfrom
fix-heredoc

Conversation

@kkozik-amplify
Copy link
Collaborator

this fixes #190

@kkozik-amplify kkozik-amplify marked this pull request as ready for review February 25, 2025 12:53
@kkozik-amplify kkozik-amplify requested a review from a team as a code owner February 25, 2025 12:53
@kkozik-amplify kkozik-amplify changed the title heredoc parsing: require ending delimiter to be on its own line with possible indentation heredoc parsing: require ending delimiter to be on its own line with optional indentation Feb 25, 2025
@rddimon
Copy link
Contributor

rddimon commented Feb 25, 2025

Is it possible to cover by test?

@kkozik-amplify
Copy link
Collaborator Author

@rddimon extended existing test with the case reported in #190

@kkozik-amplify kkozik-amplify merged commit fbbd7b6 into main Feb 25, 2025
12 checks passed
@kkozik-amplify kkozik-amplify deleted the fix-heredoc branch February 25, 2025 13:11
@kkozik-amplify kkozik-amplify mentioned this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue handling heredoc with delimiter within text itself

3 participants