Conversation
polbins
force-pushed
the
pintal/AMP-149057/fix-session-handling-without-lifecycle-autocapture
branch
from
f5d4357 to
1151016
Compare
polbins
changed the title
crleona
approved these changes
Feb 13, 2026
polbins
deleted the
pintal/AMP-149057/fix-session-handling-without-lifecycle-autocapture
branch
github-actions bot
pushed a commit
that referenced
this pull request
Feb 17, 2026
## [1.25.2](v1.25.1...v1.25.2) (2026-02-17) ### Bug Fixes * always register activity lifecycle callbacks for accurate session tracking ([#355](#355)) ([3624d45](3624d45))
|
🎉 This PR is included in version 1.25.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR is addressing
Fixes #354. With default config (
autocapture = setOf(SESSIONS)), activity lifecycle callbacks were never registered, soforegroundstayedfalseand sessions reset afterminTimeBetweenSessionsMilliseven while the user was in-app.Describe the solution
Always register activity lifecycle callbacks. Autocapture events are already individually guarded in
AndroidLifecyclePlugin, so this only makes foreground detection always-on. Removes the now-deadREQUIRES_ACTIVITY_CALLBACKSconstant and its test.Steps to verify the change
UT and manual
Checklist
Note
Low Risk
Small behavior change limited to always-on lifecycle callback registration; main risk is minor overhead or unintended lifecycle side effects, but no auth/data-flow logic changes.
Overview
Always registers
ActivityLifecycleObserverinAmplitudeinitialization, instead of doing so only when certainautocaptureoptions are enabled, ensuring foreground/session state stays accurate even with session-only tracking.Removes the now-unused
AutocaptureOption.REQUIRES_ACTIVITY_CALLBACKSconstant and deletes its unit test coverage.Written by Cursor Bugbot for commit 1151016. This will update automatically on new commits. Configure here.