fix: prevent race condition in concurrent fetch requests#60
Open
RyanLRKuhn wants to merge 5 commits intoamplitude:mainfrom
Open
fix: prevent race condition in concurrent fetch requests#60RyanLRKuhn wants to merge 5 commits intoamplitude:mainfrom
RyanLRKuhn wants to merge 5 commits intoamplitude:mainfrom
Conversation
Author
|
Any chance someone could take a look at this? Pretty light lift to ensure the SDK is always storing the latest fetch results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a race condition where concurrent fetch requests could result in an older response overwriting a newer one. This occurred when a later fetch request completed before an earlier one, causing stale data to be stored.
Changes
storeVariants()to only store responses from the most recent fetchTest Plan
__tests__/race-condition.test.tswith two test cases:Technical Details
The fix introduces two instance variables:
fetchSequenceNumber: Increments with each new fetch requeststoredFetchSequenceNumber: Tracks the sequence number of the currently stored dataWhen storing variants, the method now checks if the incoming sequence number is newer than what's already stored. If not, the stale response is discarded with a debug log message.
This ensures that in scenarios where:
...the client will correctly store data from Fetch B and ignore the stale response from Fetch A.