-
Notifications
You must be signed in to change notification settings - Fork 382
Fix parsing of class names like 'w-1/3' as used in selectors like '.w-1\/3' #4610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Build for testing: amp.zip (v1.5.4-alpha-20200420T213813Z-70cee0e15) |
| diff --git a/lib/Sabberworm/CSS/RuleSet/DeclarationBlock.php b/lib/Sabberworm/CSS/RuleSet/DeclarationBlock.php | ||
| index e18f5d8..26c2e12 100644 | ||
| --- a/lib/Sabberworm/CSS/RuleSet/DeclarationBlock.php | ||
| +++ b/lib/Sabberworm/CSS/RuleSet/DeclarationBlock.php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that SabberWorm PHP CSS Parser seems to use PSR-2/PSR-12, not WPCS, so code style needs to be adapted if this is to be merged into the upstream package.
pierlon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise from @schlessera's note above, this looks good 👍 .
|
I'll keep this to the v1.6 release since updating the CSS parser could have big impacts. |
Summary
master.patches/php-css-parser-138-extended.patch(introduced in Require unreleased version of PHP-CSS-Parser #4300) which was merged intomaster.Fixes #4609
Checklist