Update allowed tags/attributes from spec in amphtml to 2005050322002 #4701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…phtml-2005050322002 * 'develop' of github.com:ampproject/amp-wp: (47 commits) Adapt docblocks Display PHPStan version in Travis Update dependency eslint-plugin-jest to v23.13.1 Adapt in libraries as well Always download latest version of PHPStan Update dependency autoprefixer to v9.8.0 Update dependency eslint-plugin-jest to v23.13.0 Fix phpdoc for sanitizer_classes and embed_handler_classes Remove array_column() polyfill since plugin requires PHP 5.6+ Update dependency @wordpress/scripts to v9.1.0 Remove redundant subtraction Raise level to 3 Adapt type-hint for AMP_Image_Dimension_Extractor::normalize_url() Use empty string for pruning textContent Adapt typehint for AMP_Content->sanitizer_classes Adapt typehint for AMP_Tag_And_Attribute_Sanitizer->allowed_tags Adapt typehints for methods returning a rule spec check result Adapt typehint for AMP_Style_Sanitizer->current_sources Adapt return typehint for AMP_YouTube_Embed_Handler::get_video_id_from_url() Adapt return value for failed AMP_Twitter_Embed_Handler::get_tweet_id() ...
6 tasks
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously #4548.
./bin/amphtml-update.sh(lando ssh -c 'bash ./bin/amphtml-update.sh vendor/amphtml').Update spec generator as needed based on spec format changes.Modify validating sanitizer based on changes to spec, if needed.Changelog
amp-stateandtemplateinamp-story-grid-layer.show-tooltipattribute toaelements (only relevant to stories apparently).[data-tweetid]AMP-bind attribute onamp-twitter.srconamp-ad-customelements.amp-story-page-attachment[href]spec.blacklisted_value_regexfromstyleattributes. This is not because!importantis now allowed, but because the validator is now doing CSS parsing. This meansfont_url_specandimage_url_specare removed from the CSS validator spec; a newdoc_css_bytesproperty is added which apparently refers to gathering the byte length ofstyleattributes to add tostyle[amp-custom], which isn't relevant for the plugin since all inline styles are transformed to style rules.enterkeyhintattribute toinput(and other input-like AMP components).Details
( PREV_VERSION=2004142326360; THIS_VERSION=2005050322002; git checkout $THIS_VERSION; git diff $PREV_VERSION...$THIS_VERSION -w -- $( git ls-files | grep '.protoascii' ); git checkout - > /dev/null )2004142326360...2005050322002