Skip to content

Update amp_remove_admin_bar_in_phone_preview() to use wp_print_inline_script_tag() #8125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update amp_remove_admin_bar_in_phone_preview() to use wp_print_inline_script_tag() #8125

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0ee1e7
Update amp_remove_admin_bar_in_phone_preview() to use wp_print_inline…
westonruter Nov 11, 2025
9a0619e
Use short array syntax
westonruter Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion includes/amp-helper-functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,10 @@ function amp_remove_admin_bar_in_phone_preview() {
if ( ! amp_is_dev_mode() || ! is_admin_bar_showing() ) {
return;
}

ob_start();
?>
<script data-ampdevmode>
<script>
( () => {
if ( 'amp-wizard-completion-preview' !== window.name ) {
return;
Expand All @@ -226,6 +228,8 @@ function amp_remove_admin_bar_in_phone_preview() {
} )();
</script>
<?php
$script = str_replace( [ '<script>', '</script>' ], '', ob_get_clean() );
wp_print_inline_script_tag( $script, [ 'data-ampdevmode' => true ] );
}

/**
Expand Down
Loading