feat: Performance boost with Promise.all concurrency 🚀#40212
Open
sanjaiyan-dev wants to merge 3 commits intoampproject:mainfrom
Open
feat: Performance boost with Promise.all concurrency 🚀#40212sanjaiyan-dev wants to merge 3 commits intoampproject:mainfrom
sanjaiyan-dev wants to merge 3 commits intoampproject:mainfrom
Conversation
|
|
Member
|
heya looks like the build is broken because of a chrome issue that we are currently trying to resolve. once it is fixed, we'll need to rebase this. I'll ping this thread once we've merged the workaround. |
Member
|
the issue has been temporarily resolved thru #39912 . Please rebase this PR and ping me when ready. Thank for for submitting this optimization! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves performance by switching to concurrent execution of asynchronous operations using
Promise.all. Previously, these operations were sequential, increasing processing time.Promise.allallows multiple promises to resolve concurrently, significantly reducing the overall execution time when dealing with independent asynchronous tasks. This is especially beneficial when I/O bound operations are involved, as the CPU can work on other tasks while waiting for responses.Extremely sorry if I made any mistakes.