Feature/add channelid #40266
Open
Feature/add channelid #40266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aylist - Introduced a new property `channelid_` to capture the data-channelid attribute. - Updated buildCallback() to read data-channelid. - Modified getEmbedUrl_() to convert channel IDs (UC…) to uploads playlist IDs (UU…) by replacing “UC” with “UU”. - Updated assertDatasourceExists_() to validate data-channelid alongside other attributes. This change enables embedding a channel’s uploads playlist as a better alternative since direct channel embedding is not supported.
|
|
|
👋 Hi maintainers! I'm a beginner contributor, and I'm running into issues resolving the import paths for services and event-helper after the recent structure updates. Could someone kindly guide me on where to import these from now? I’d love to get this working and learn from the fix 🙏 Thanks in advance for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the amp-youtube component by adding support for a new attribute, data-channelid. Instead of embedding a channel directly—which YouTube does not support in AMP—this feature converts the provided channel ID (which starts with "UC") into its corresponding uploads playlist ID (by replacing "UC" with "UU"). This approach allows developers to embed the channel's uploads playlist, ensuring that the latest videos from the channel are displayed.
Changes
channelid_to store the value from data-channelid.Testing
Related Issues
Closes #[26304] (if applicable)
Conclusion
This PR provides a robust solution for embedding a YouTube channel’s uploads playlist in AMP, addressing the limitation that YouTube does not support direct channel embedding. Please review the changes and provide feedback.