refactor: replace deprecated 'context.master' with 'context.primary' for inclusive language (#33068) #40357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates all references of
context.master
tocontext.primary
across the AMPHTML codebase as part of an inclusive language refactor, in alignment with issue #33068.The following changes were made:
ampcontext-integration.js
: Refactored theIntegrationAmpContext
class andmasterSelection()
function.3p.js
: UpdatedcomputeInMasterFrame()
usage fromglobal.context.master
toglobal.context.primary
.test-3p.js
: Updated all test setup references usingcontext.master
.No functional or behavioral changes were introduced. This is a semantic change to align with inclusive coding standards.
Motivation
The use of terms like "master" can be problematic and non-inclusive. This refactor improves code readability and ensures the project aligns with modern inclusive language practices.
Notes
context.slave
is not used anywhere in the codebase.Closes: #33068