Skip to content

♻ Ensure Newline at EOF is Consistently Rendered and Fixed JSON Formatting in VS Code #40406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nayanika-Acharjee wants to merge 3 commits into from
Closed

♻ Ensure Newline at EOF is Consistently Rendered and Fixed JSON Formatting in VS Code #40406

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7db0ec2
fixed-file
Nayanika-Acharjee Oct 4, 2025
913c384
Fixed settings.json
Nayanika-Acharjee Oct 4, 2025
ef5ca23
Delete .vscode/settings.json.fixed.json
Nayanika-Acharjee Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 6 additions & 19 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,36 +1,23 @@
{
"files.associations": {
// Enable JSON5 syntax highlighting and auto-formatting for OWNERS files.
// Until VS Code adds native JSON5 support, this needs
// https://marketplace.visualstudio.com/items?itemName=mrmlnc.vscode-json5
"OWNERS": "json5",

// Enable JSON auto-formatting for these files.
".prettierrc": "json",
".renovaterc.json": "json",

// Allow comments in JSON schema files.
"*.schema.json": "jsonc"
},

"files.insertFinalNewline": true,
"editor.renderFinalNewline": true,

// Auto-fix JS files with ESLint using amphtml's custom settings. Needs
// https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint
"editor.codeActionsOnSave": {
"source.fixAll.eslint": "explicit"
},
"[js]": {"editor.formatOnSave": false},

// Auto-fix non-JS files with Prettier using amphtml's custom settings. Needs
// https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode
"[yaml]": {"editor.formatOnSave": true},
"[json]": {"editor.formatOnSave": true},
"[json5]": {"editor.formatOnSave": true},
"[markdown]": {"editor.formatOnSave": true},
"[js]": { "editor.formatOnSave": false },
"[yaml]": { "editor.formatOnSave": true },
"[json]": { "editor.formatOnSave": true },
"[json5]": { "editor.formatOnSave": true },
"[markdown]": { "editor.formatOnSave": true },

// Validate JSON schemas on the fly. Also used by the `amp check-json-schemas`
// task. Do not use URLs from the web, they are unsupported by this task.
"json.schemas": [
{
"fileMatch": [
Expand Down