PPC MMA implementation #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amrita H S <[email protected]>
| __builtin_mma_disassemble_acc(vec_C, ACC); \ | ||
| for (int I = 0; I < 4; I++) { \ | ||
| for (int J = 0; J < 4; J++) { \ | ||
| *((float*)(C+ii+((jj+J)*ldc)+I)) = *((float*)&vec_C[I]+J); \ |
There was a problem hiding this comment.
It's probably better to do a 4 vector transpose here or invert the MMA inputs. That way you can write vectors at a time instead of scalar elements.
| aoffset1 += 8*lda; | ||
| aoffset2 += 8*lda; | ||
| aoffset3 += 8*lda; | ||
| aoffset4 += 8*lda; |
There was a problem hiding this comment.
How come aoffset5 - 8 are not updated here? Could this be the reason it only works for multiples of 8?
| string(FIND ${POWER10_M} "POWER10" substring_index) | ||
| if(${substring_index} GREATER_EQUAL 0) | ||
| list(APPEND ARCH_FLAGS -mcpu=power10) | ||
| elseif (${CMAKE_SYSTEM_PROCESSOR} MATCHES "ppc64le") |
There was a problem hiding this comment.
Is it possible for CMAKE_SYSTEM_PROCESSOR to match both ppc64 and ppc64le?
| vector float t1, t2, t3, t4; | ||
| c1 = vec_xl(0, aoffset1); | ||
| c2 = vec_xl(0, aoffset2); | ||
| c3 = vec_xl(0, aoffset3); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPC MMA implementation for llamafile_sgemm API