Code refactor #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amrita H S <[email protected]>
amritahs-ibm
force-pushed
the
code_refactor
branch
from
19180b1 to
c6335a1
Compare
|
0001-Code-Refactoring.patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, I have tried to reduce the duplication in the source code by using inline functions. (As usage of MACROS is not appreciated).
Code can be further refactored by using base and derived classes, so that we will not have one class for each datatype. I had tried this change locally, but it led to performance issues. So this needs further work.(I will be attaching those changes in the next comment).