DNM: Convert the :sample app to Metro
#129
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vRallev
force-pushed
the
rwo/sample-app
branch
2 times, most recently
from
d4ac6b2 to
b7b102d
Compare
**DO NOT MERGE:** Metro's aggregation (Anvil) features are not working for other KMP targets than JVM/Android yet. This maybe will be resolved in Kotlin 2.3: https://youtrack.jetbrains.com/issue/KT-75865 This PR, nonetheless, is a proof of concept of using Metro with App Platform in an application and how a migration could look like. Migrate the `:sample` app from kotlin-inject to Metro. This change also renames "component" interfaces to "graph" interfaces. Fixes #127
vRallev
force-pushed
the
rwo/sample-app
branch
from
b7b102d to
74b0e2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: Metro's aggregation (Anvil) features are not working for other KMP targets than JVM/Android yet. This maybe will be resolved in Kotlin 2.3: https://youtrack.jetbrains.com/issue/KT-75865 This PR, nonetheless, is a proof of concept of using Metro with App Platform in an application and how a migration could look like.
Migrate the
:sampleapp from kotlin-inject to Metro. This change also renames "component" interfaces to "graph" interfaces.Fixes #127