Skip to content

Replace ipv4 inet_ntop with a handrolled function #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Replace ipv4 inet_ntop with a handrolled function #367

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3643650
Replace ipv4 inet_ntop with a handrolled function
kiroma Feb 20, 2025
e00a702
make iptos static
kiroma Feb 20, 2025
103e3f5
Make codegen better behaved on msvc / gcc
kiroma Feb 20, 2025
f7f604d
Format...
an-tao Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 30 additions & 6 deletions trantor/net/InetAddress.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,16 +196,40 @@ bool InetAddress::isLoopbackIp() const
return false;
}

static void byteToChars(std::string::iterator &dst, unsigned char byte)
{
*dst = byte / 100 + '0';
dst += byte >= 100;
*dst = byte % 100 / 10 + '0';
dst += byte >= 10;
*dst = byte % 10 + '0';
++dst;
}

static std::string iptos(unsigned inet_addr)
{
// Initialize with a static buffer to force the constructor of string to get
// fully inlined
constexpr char stringInitBuffer[15]{};
std::string out(stringInitBuffer, 15);
std::string::iterator dst = out.begin();
byteToChars(dst, inet_addr >> 0 & 0xff);
*(dst++) = '.';
byteToChars(dst, inet_addr >> 8 & 0xff);
*(dst++) = '.';
byteToChars(dst, inet_addr >> 16 & 0xff);
*(dst++) = '.';
byteToChars(dst, inet_addr >> 24 & 0xff);
out.erase(dst, out.end());
return out;
}

std::string InetAddress::toIp() const
{
char buf[64];
char buf[INET6_ADDRSTRLEN]{};
if (addr_.sin_family == AF_INET)
{
#if defined _WIN32
::inet_ntop(AF_INET, (PVOID)&addr_.sin_addr, buf, sizeof(buf));
#else
::inet_ntop(AF_INET, &addr_.sin_addr, buf, sizeof(buf));
#endif
return iptos(addr_.sin_addr.s_addr);
}
else if (addr_.sin_family == AF_INET6)
{
Expand Down