Staging/2023 r2/fix discarded qualifiers#555
Merged
Conversation
Make sure to not discard const and so mark the proper strings as they should be. To do that, don't use the same pointer on a different path where we need to g_strndup() and g_free(). Just use a local variable for that path. Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Make sure to not discard const. Hence, qualify char* as const. Signed-off-by: Nuno Sá <nuno.sa@analog.com>
nunojsa
requested review from
cristina-suteu,
dNechita and
mhennerich
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
I was not being able to compile the 2023_R2 on arch due to discarded-qualifiers warnings. This series fixes those warnings.
PR Type
PR Checklist