Madura DPD #3016

danmois · 2025-11-13T08:47:31Z

PR Description

Add DPD functionality to the Madura driver.

PR Type

Bug fix (a change that fixes an issue)
New feature (a change that adds new functionality)
Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

I have conducted a self-review of my own code changes
I have compiled my changes, including the documentation
I have tested the changes on the relevant hardware
[] I have updated the documentation outside this repo accordingly
[] I have provided links for the relevant upstream lore

gastmaier

looked into the ci output to check sanity. the two new warnings seems to be valid, I highlighted with comments.
There are extra warnings outside touched lines, that would be nice to progressively resolve.

In the files changed tab, action summary page, and log file, you can see the ci warnings

gastmaier · 2025-11-13T09:37:13Z

drivers/iio/adc/adrv902x/adrv9025.c


+	ret = sysfs_create_bin_file(&indio_dev->dev.kobj, &phy->bin);
+	if (ret < 0)
+		return ret;


From ci: shouldn't this go to the error de-initialization path?

Yes it should, thank you! I will update the function.

Also do not use the above function. Directly accessing a fundamental thing as kobjects from a driver is a very strong sign of something very odd. Use the device_create_bin_file() wrapper.

gastmaier · 2025-11-13T09:37:31Z

drivers/iio/adc/adrv902x/adrv9025.c

+
+		ret = sscanf(line, "%hhu %hhu %hhu %hhu %s", &i, &j, &k, &lut, coef);
+		if (ret != 5)
+			return ret;


From ci: this is never a error code.

True. I wonder if an error message should be displayed before returning -EINVAL?

Likely yes 😉

danmois · 2025-11-13T13:25:20Z

V2

fix error de-initialization path
display message and return correct value in case of error in adrv9025_parse_dpd_coef
use device_create_bin_file() instead of sysfs_create_bin_file()

gastmaier · 2025-11-14T13:30:36Z

drivers/iio/adc/adrv902x/adrv9025.c

 	return 0;

+out_remove_device_bin:
+	device_remove_bin_file(&phy->indio_dev->dev, &phy->bin);


Shouldn't you remove the bin file at the remove method as well?

Done. Thanks!

vasbimpikasadi · 2025-11-14T14:14:38Z

drivers/iio/adc/adrv902x/adrv9025.c

 				      !!(phy->cal_mask.calMask & val));
 		break;
+	case ADRV9025_CAL_MASK:
+		ret = sprintf(buf, "%d\n",


This may be outside the scope of this PR as it looks like a minor addition, but sysfs_emit() should be used instead of sprintf() for sysfs attributes (proper bounds checking, preferred kernel way. Just a thought, might be a chance to modernise the sysfs methods of the driver.

Hi, Vas! You are right, thank you for the observation. However, I used sprintf to keep the current structure of the driver unchanged. I am also not completely sure that we should include this refactoring in this PR, since the current version was tested as it is. From my point of view, DPD is a fairly complex addition to the driver. Do you have any recommendation regarding this @gastmaier , @nunojsa ?

Yes, I do agree we should modernize it (because copy paste is a fairly common practice for these devices and we do not want to copy old APIs all over).

That said, it needs to be in it's own patch (a precursor patch) and it should be pretty safe to do it even in this PR. I mean, it should be a matter of s/sprintf/sysfs_emit (or using an IDE replace kind of thing).

danmois · 2025-11-17T06:49:15Z

V3

remove bin file at the remove method as well

danmois · 2025-11-17T09:14:14Z

V4

use sysfs_emit instead of sprintf

danmois · 2025-11-17T09:58:44Z

V5

fix status display

Address CI warnings. No functional change. Signed-off-by: George Mois <[email protected]>

Use sysfs_emit instead of sprintf. Use safe functions for formatting buffers. Signed-off-by: George Mois <[email protected]>

Add Orx to Tx mapping setting functionality. Signed-off-by: George Mois <[email protected]>

Add external path delay initial calibration selection. Signed-off-by: George Mois <[email protected]>

Add an IIO attribute that allows changing the calibration mask. Signed-off-by: George Mois <[email protected]>

Add a bin_attribute for loading the data structure to hold Tx DPD Model initialization parameters, without floats. Signed-off-by: George Mois <[email protected]>

Add IIO attribute for selecting the target Tx channel for DPD. Signed-off-by: George Mois <[email protected]>

Add IIO attribute for resetting DPD. Signed-off-by: George Mois <[email protected]>

Add DEBUGF attribut for getting DPD status on each of the 4 Tx channels. Signed-off-by: George Mois <[email protected]>

Add tracking configuration settings. Signed-off-by: George Mois <[email protected]>

Add IIO attribute for enabling DPD. Signed-off-by: George Mois <[email protected]>

danmois · 2025-11-18T07:54:10Z

V6

address CI warnings

danmois requested review from CiprianRegus, amiclaus, btogorean, buha, chegbeli, dbogdan, machschmitt, mhennerich, nunojsa and rbolboac as code owners November 13, 2025 08:47

gastmaier requested changes Nov 13, 2025

View reviewed changes

danmois force-pushed the staging/madura_dpd branch from ddd8c1a to 1457283 Compare November 13, 2025 13:22

gastmaier reviewed Nov 14, 2025

View reviewed changes

vasbimpikasadi reviewed Nov 14, 2025

View reviewed changes

danmois force-pushed the staging/madura_dpd branch from 1457283 to 188092e Compare November 17, 2025 06:43

danmois force-pushed the staging/madura_dpd branch from 188092e to a0111c2 Compare November 17, 2025 09:13

danmois force-pushed the staging/madura_dpd branch from a0111c2 to 243ed4c Compare November 17, 2025 09:58

danmois force-pushed the staging/madura_dpd branch 2 times, most recently from 567c271 to db4f953 Compare November 17, 2025 15:39

danmois added 7 commits November 18, 2025 09:46

iio: adc: adrv902x: Address CI warnings

6eb5e10

Address CI warnings. No functional change. Signed-off-by: George Mois <[email protected]>

iio: adc: adrv902x: Use sysfs_emit

57ced40

Use sysfs_emit instead of sprintf. Use safe functions for formatting buffers. Signed-off-by: George Mois <[email protected]>

iio: adc: adrv902x: Add ORx to Tx mapping

60deeae

Add Orx to Tx mapping setting functionality. Signed-off-by: George Mois <[email protected]>

iio: adc: adrv902x: Add external path delay calib

958a982

Add external path delay initial calibration selection. Signed-off-by: George Mois <[email protected]>

iio: adc: adrv902x: Change calibration mask

3718195

Add an IIO attribute that allows changing the calibration mask. Signed-off-by: George Mois <[email protected]>

iio: adc: adrv902x: Load DPD model config

f31ad65

Add a bin_attribute for loading the data structure to hold Tx DPD Model initialization parameters, without floats. Signed-off-by: George Mois <[email protected]>

iio: adc: adrv902x: Select Tx DPD mask

6437370

Add IIO attribute for selecting the target Tx channel for DPD. Signed-off-by: George Mois <[email protected]>

danmois added 4 commits November 18, 2025 09:46

iio: adc: adrv902x: Enable DPD reset

6831108

Add IIO attribute for resetting DPD. Signed-off-by: George Mois <[email protected]>

iio: adc: adrv902x: Add DPD status

e965c62

Add DEBUGF attribut for getting DPD status on each of the 4 Tx channels. Signed-off-by: George Mois <[email protected]>

iio: adc: adrv902x: Add tracking config

4193c38

Add tracking configuration settings. Signed-off-by: George Mois <[email protected]>

iio: adc: adrv902x: Add DPD enable functionality

523346f

Add IIO attribute for enabling DPD. Signed-off-by: George Mois <[email protected]>

danmois force-pushed the staging/madura_dpd branch from db4f953 to 523346f Compare November 18, 2025 07:53

Madura DPD #3016

Are you sure you want to change the base?

Madura DPD #3016

Conversation

danmois commented Nov 13, 2025

PR Description

PR Type

PR Checklist

Uh oh!

gastmaier left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danmois commented Nov 13, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danmois Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danmois commented Nov 17, 2025

Uh oh!

danmois commented Nov 17, 2025

Uh oh!

danmois commented Nov 17, 2025

Uh oh!

danmois commented Nov 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gastmaier left a comment •

edited

Loading

danmois Nov 17, 2025 •

edited

Loading