Merged
Conversation
Use simpler version enviroment variable, to standarize container versioning internally. Set entrypoint to bash by default, since is the most desired behaviour when running locally, being entrypoint.sh only useful on systemd files, which can set the `--entrypoint` anyway. Signed-off-by: Jorge Marques <jorge.marques@analog.com>
The painpoint of the runner name now resolves internally, and the entrypoint defaults to bash (most users usage), then append to the systemd run command. Signed-off-by: Jorge Marques <jorge.marques@analog.com>
Just use podman, with the first with '# or docker, ...' comment, it should be enough for most users. Signed-off-by: Jorge Marques <jorge.marques@analog.com>
pamolloy
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
I standardized the container version as a environment variable called
version(couldn't come up with a better name, unfortunately.)this tag is read while building the container during the ci/cd to auto-tag.
Another change is to default the container to the shell, since the entry-point can be easily injected in the systemd file and most users will want to use the shell anyway.
For the docs, just tag as
latest, so user can justdocker run -it adi/linux, providing less friction (does not deprecate container-run.sh , that script still provides nice aliases, even a way to mount ai with the--mount-ai).runner_labelsif not set, defaults torepo-only, then always suffixed with version, so in practice$version,repo-onlyThe main motivation for the changes is to not have to touch the systemd files on tag bumps, since the version context is in the container now (overwriting name_label,runner_labels don't overwrite the 'implicit' version, because it is not implicit anymore).
PR Type
PR Checklist