Drop old AD7946 and AD7984 device trees#3208
Merged
nunojsa merged 2 commits intoanalogdevicesinc:mainfrom Mar 27, 2026
Merged
Conversation
The old device tree for AD7946 describes hardware in a way that is substantially different and incompatible with how we currently describe AD7946. On top of that, it uses a deprecated device driver compatible string. We already have a new device tree for AD7946 (zynq-coraz7s-ad7946-pmdz.dts), which better describes AD7946 and uses the new, upstreamed, device driver for PulSAR and similar ADCs. Drop the old AD7946 dts in favor of the new one. Signed-off-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
The old device tree for AD7984 describes hardware in a way that is substantially different and incompatible with how we currently describe AD7984. On top of that, it uses a deprecated device driver compatible string. We already have a new device tree for AD7984 (zynq-coraz7s-ad7984-pmdz.dts), which better describes AD7984 and uses the new, upstreamed, device driver for PulSAR and similar ADCs. Drop the old AD7984 dts in favor of the new one. Signed-off-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
Collaborator
Do we have a plan or estimate for when we can add spi offloading to ad7689? |
nunojsa
approved these changes
Mar 26, 2026
Collaborator
|
BTW, why is this a draft? Do wee need some other stuff first merged? |
Contributor
Author
No. Well, we would need to update ad7949.c to provide offload support. Provided approval and evaluation hardware, I may work on that. Anyways, this PR doesn't need anything else so yes, officially opening it. |
machschmitt
requested review from
CiprianRegus,
amiclaus,
btogorean,
buha,
chegbeli,
danmois,
dbogdan,
mhennerich,
rbolboac and
stefpopa
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
After we updates to ad7768-1 (#3170), ad4134 (#3194), and ad_sigma_delta (#3196), ad_pulsar will be the only remaining user of legacy SPI Engine. AD7689 is only one part supported by drivers/iio/adc/ad_pulsar.c driver that is not yet fully supported by a different driver. AD7689 is supported both by ad_pulsar.c (ADI only) and ad7949.c (upstream and ADI). Though, we don't support AD7689 with SPI offloading with ad7949.c. So, in practice, zynq-coraz7s-ad7689-ardz.dts will be the only user of legacy SPI Engine since all other devices are going to be using the new stuff.
PR Type
PR Checklist