Skip to content

iio: trx-rf: ad9088: fix __counted_by misuse in ad9088_clk_register() #3215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nunojsa merged 1 commit into from
Mar 27, 2026
Merged

iio: trx-rf: ad9088: fix __counted_by misuse in ad9088_clk_register() #3215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion drivers/iio/trx-rf/ad9088/ad9088.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
// SPDX-License-Identifier: GPL-2.0
/*
* Driver for AD9088 and similar mixed signal front end (MxFE®)
Expand Down Expand Up @@ -61,8 +61,8 @@
while (*frac_a >= (1 << 24) || *frac_b >= (1 << 24)) {
*frac_a >>= 1;
*frac_b >>= 1;
};

Check warning on line 64 in drivers/iio/trx-rf/ad9088/ad9088.c

View workflow job for this annotation

GitHub Actions / checks / checks 

coccicheck: 3-4  Unneeded semicolon
};

Check warning on line 65 in drivers/iio/trx-rf/ad9088/ad9088.c

View workflow job for this annotation

GitHub Actions / checks / checks 

coccicheck: 2-3  Unneeded semicolon

if (neg)
*ftw = (1ULL << bits) - *ftw;
Expand Down Expand Up @@ -1222,7 +1222,7 @@
return ret;

phy->clks[source] = clk_priv->hw.clk;
phy->clk_data->hws[phy->clk_data->num++] = &clk_priv->hw;
phy->clk_data->hws[source] = &clk_priv->hw;

return 0;
}
Expand Down Expand Up @@ -5215,6 +5215,11 @@
if (!phy->clk_data)
return -ENOMEM;

/*
* Even though we already allocate NUM_AD9088_CLKS, RX_SAMPL_CLK_LINK2 is still
* not being registered, hence the -1.
*/
phy->clk_data->num = NUM_AD9088_CLKS - 1;
ret = ad9088_clk_register(phy, "-rx_sampl_clk", __clk_get_name(dev_clk), NULL,
CLK_GET_RATE_NOCACHE | CLK_IGNORE_UNUSED, RX_SAMPL_CLK);
if (ret)
Expand Down
Loading