Add support for MAX17616 by cjones-adi · Pull Request #2734 · analogdevicesinc/no-OS

cjones-adi · 2025-09-25T04:13:33Z

Pull Request Description

The MAX17616/MAX17616A offers highly versatile and programmable protection boundaries for systems against input voltage faults and output overcurrent faults. Input-voltage faults (with positive polarity) are protected up to +80V (without Reverse Current Protection)/+75V (with Reverse Current Protection), by an internal nFET featuring low ON-resistance (20mΩ typ). The devices feature a programmable undervoltage-lockout (UVLO) thresholds by using external voltage- dividers. The MAX17616 features a programmable overvoltage-lockout (OVLO) while MAX17616A offers a programmable output voltage clamp function through the OVFB pin that features an output voltage limiting regulation during input transient surge events. Input undervoltage and overvoltage protection (MAX17616)/output voltage clamp function (MAX17616A) can be programmed across the entire 3V to 80V operating range.

PR Type

Bug fix (change that fixes an issue)
New feature (change that adds new functionality)
Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

I have followed the Coding style guidelines
I have complied with the Submission Checklist
I have performed a self-review of the changes
I have commented my code, at least hard-to-understand parts
I have build all projects affected by the changes in this PR
I have tested in hardware affected projects, at the relevant boards
I have signed off all commits from this PR
I have updated the documentation (wiki pages, ReadMe etc), if applies

CLAassistant · 2025-09-25T04:13:40Z

All committers have signed the CLA.

buha · 2025-09-29T12:44:11Z

/AzurePipelines run

azure-pipelines · 2025-09-29T12:44:23Z

Azure Pipelines successfully started running 2 pipeline(s).

kister-jimenez · 2025-09-30T01:29:40Z

/AzurePipelines run

azure-pipelines · 2025-09-30T01:29:53Z

Azure Pipelines successfully started running 2 pipeline(s).

cjones-adi · 2025-09-30T04:26:44Z

V2:

Rebase to latest main
Move max17616.rst to respective doc/sphinx/source directory
Fix astyle errors on identified files

kister-jimenez · 2025-09-30T06:59:29Z

/AzurePipelines run

azure-pipelines · 2025-09-30T06:59:41Z

Azure Pipelines successfully started running 2 pipeline(s).

cjones-adi · 2025-10-01T02:34:19Z

V3:

Resolve identified Sphinx documentation errors

jemfgeronimo · 2025-10-01T02:45:35Z

/AzurePipelines run

azure-pipelines · 2025-10-01T02:45:47Z

Azure Pipelines successfully started running 2 pipeline(s).

cjones-adi · 2025-10-01T04:12:19Z

V4:

Remove diff headers included in max17616.h

cjones-adi · 2025-10-01T22:47:48Z

/AzurePipelines run

azure-pipelines · 2025-10-01T22:47:54Z

Commenter does not have sufficient privileges for PR 2734 in repo analogdevicesinc/no-OS

kister-jimenez · 2025-10-02T02:17:07Z

/AzurePipelines run

azure-pipelines · 2025-10-02T02:17:21Z

Azure Pipelines successfully started running 2 pipeline(s).

kseerp

Hi, minor comments on my end.

kseerp · 2025-10-28T07:34:16Z

drivers/power/max17616/max17616.c

+		if (ret == 0)
+			*value = max17616_direct_to_int(raw_value,
+							&max17616_vin_coeffs);


error handling be done first, and only do the value conversion if the read was successful

ret = max17616_read_word(dev, MAX17616_CMD(MAX17616_READ_VIN), &raw_value); if (ret) return ret; *value = max17616_direct_to_int(raw_value, &max17616_vin_coeffs);

Thanks. Fixed in latest commit.

kseerp · 2025-10-28T07:37:26Z

drivers/power/max17616/max17616.c

+	case MAX17616_POWER:
+		/* Calculate power from voltage and current */
+	{
+		int vin, iout;


variable declarations should be moved to top of function

Thanks. Fixed in latest commit.

kseerp · 2025-10-28T07:37:34Z

drivers/power/max17616/max17616.c

+		if (ret == 0)
+			*value = vin * iout;


error handling be done first before processing success case

Thanks. Fixed in latest commit.

kseerp · 2025-10-28T07:38:04Z

drivers/power/max17616/max17616.c

+	int ret = max17616_read_byte(dev,MAX17616_CMD(MAX17616_OPERATION),
+				   &operation);
+
+	if (ret == 0)
+		*enabled = (operation & 0x80) ? true : false;


Thanks. Fixed in latest commit.

kseerp · 2025-10-28T07:38:08Z

drivers/power/max17616/max17616.c

+
+	/* Extract bits 7:6 and convert to enum */
+	switch (raw_value & 0xC0) {
+	case 0x00:


consider using macros in switch cases

Thanks. Fixed in latest commit.

kseerp · 2025-10-28T07:38:15Z

drivers/power/max17616/max17616.c

+
+	/* Extract bits 3:0 and convert to enum */
+	switch (raw_value & 0x0F) {
+	case 0x00:


Thanks. Fixed in latest commit.

kseerp · 2025-10-28T07:39:08Z

drivers/power/max17616/max17616.h

+	MAX17616_STATUS_BIT_GENERAL	= 0,	// Not supported
+	MAX17616_STATUS_BIT_CML		= 1,	// Comms, memory, or logic Fault
+	MAX17616_STATUS_BIT_TEMPERATURE	= 2,	// Temperature Fault or Warning
+	MAX17616_STATUS_BIT_VIN_UV	= 3,	// Input Under Voltage Fault
+	MAX17616_STATUS_BIT_IOUT_OC	= 4,	// Output Over Current Fault
+	MAX17616_STATUS_BIT_VOUT_OV	= 5,	// An output overvoltage fault occurred
+	MAX17616_STATUS_BIT_OFF		= 6,	// Max17616 is not enabled
+	MAX17616_STATUS_BIT_BUSY	= 7	// Not supported


no need for explicit numbering since enum values are already in correct order

Thanks. Fixed in latest commit.

kseerp · 2025-10-28T07:39:13Z

drivers/power/max17616/max17616.h

+	MAX17616_STATUS_BIT_STARTUP	= 0,	// Not supported
+	MAX17616_STATUS_BIT_OTHER	= 1,	// Not supported
+	MAX17616_STATUS_BIT_FANS	= 2,	// Not supported
+	MAX17616_STATUS_BIT_POWER_GOOD	= 3,	// Not supported
+	MAX17616_STATUS_BIT_MFR		= 4,	// Manufacturer specific Fault
+	MAX17616_STATUS_BIT_INPUT	= 5,	// Input V, I, or P Fault
+	MAX17616_STATUS_BIT_IOUT_POUT	= 6,	// Output current or power Fault
+	MAX17616_STATUS_BIT_VOUT	= 7	// Output voltage Fault


Thanks. Fixed in latest commit.

amiclaus

looks good overall, some inline comments.

amiclaus · 2026-01-20T11:54:59Z

drivers/power/max17616/max17616.c

+			     uint8_t *data, size_t nbytes)
+{
+	int ret;
+	uint8_t rxbuf[nbytes + 2];


use a fixed max buffer size/dynamic allocation.

Fixed buffer size allocation to 256

amiclaus · 2026-01-20T11:55:34Z

drivers/power/max17616/max17616.c

+{
+	uint16_t raw_value;
+	int ret;
+	float vin, iout;


float values are discouraged for no-os drivers.

Replaced all float instances with uint32_t and adjusted calculations

amiclaus · 2026-01-20T11:56:37Z

drivers/power/max17616/max17616.c

+
+	case MAX17616_POWER:
+		/* Calculate power from voltage and current: P = V × I */
+		ret = max17616_read_value(dev, MAX17616_VOUT, &vin);


we store vout or vin here? if vout then use an appropriate naming.

Used correct parameter

amiclaus · 2026-01-20T11:57:37Z

drivers/power/max17616/iio_max17616.c

+	if (!iio_desc)
+		return -ENODEV;
+
+	if (iio_desc->iio_dev)


iio_desc->max17616_dev ?

Corrected the struct member to validate

amiclaus · 2026-01-20T11:58:16Z

drivers/power/max17616/max17616.h

+	MAX17616_VIN,		/* Input voltage in volts */
+	MAX17616_VOUT,		/* Output voltage in volt */
+	MAX17616_IOUT,		/* Output current in amps */
+	MAX17616_TEMP,		/* Temperature in degreesCelsius */


nit: degrees Celsius

Placed a space in between

amiclaus · 2026-01-20T12:01:16Z

drivers/power/max17616/max17616.c

+		return -EINVAL;
+
+	return max17616_write_byte(dev, MAX17616_CMD(MAX17616_SET_ISTART_RATIO),
+				   (uint8_t)istart_ratio);


any istart_ratio value is valid?

Provided the default values as per datasheet in the initialization

amiclaus · 2026-01-20T12:01:52Z

drivers/power/max17616/max17616.c

+		return -EINVAL;
+
+	/* Combine voltage selection (bits 4:2) and PGOOD threshold (bits 1:0) */
+	reg_value = ((uint8_t)voltage << 2) | (uint8_t)threshold;


consider using field preparation functions + macros.

Used no-OS field preparation macros

cjones-adi · 2026-02-02T04:54:15Z

V12

Rebased to latest main
Addressed PR comments (used no-OS bit field preparation macros, replaced float with uint32_t, provide manufacturer-specific configuration initialization values, corrected the IIO struct member to validate device removal, etc.)

amiclaus · 2026-02-02T09:34:50Z

drivers/power/max17616/max17616.c

+ * Since R = -1 for all MAX17616 coefficients:
+ * X_milli = ((Y x 10 - b) x 1000) / m
+ */
+static float max17616_direct_to_milliunit(uint16_t raw_value,


why float if it returns an int32_t ?

Thanks. This was overlooked. Changed function return with proper data type.

amiclaus · 2026-02-02T09:36:37Z

tests/drivers/power/max17616/test/test_max17616.c

+	test_expected_read_length = 2;
+	no_os_get_unaligned_le16_ExpectAndReturn(response_data, 0x3040);
+
+	int result = max17616_read_value(&device, MAX17616_VIN, &value);


the function expects an int32_t not a float.

Updated test variable data type in this test case.

amiclaus · 2026-02-02T09:36:50Z

tests/drivers/power/max17616/test/test_max17616.c

+	no_os_i2c_read_IgnoreAndReturn(0);
+	no_os_get_unaligned_le16_IgnoreAndReturn(0x2000);  // IOUT value
+
+	result = max17616_read_value(&device, MAX17616_POWER, &value);


Updated test variable data type in this test case.

amiclaus · 2026-02-02T09:37:18Z

tests/drivers/power/max17616/test/test_max17616.c

+	float value = 0.0f;
+
+	// Test with NULL device
+	int result = max17616_read_value(NULL, MAX17616_VIN, &value);


same. please check all occurences where u pass float to a function that expects int32_t

Updated test variable data type in this test case. Also updated lines 1317, 1325, 1333, and 1524.

amiclaus · 2026-02-02T09:37:30Z

tests/drivers/power/max17616/test/test_max17616.c

+	TEST_ASSERT_EQUAL_INT(-EINVAL, result);
+
+	// Test with NULL value pointer
+	result = max17616_read_value(&device, MAX17616_VIN, NULL);


Updated test variable data type in this test case.

amiclaus · 2026-02-02T09:45:05Z

tests/drivers/power/max17616/test/support/test_max17616_support.c

+
+	/* Check reasonable ranges for valid values */
+	if (telemetry->valid_mask & 0x01) { /* VIN */
+		if (telemetry->vin_mv < 0 || telemetry->vin_mv > 1000) { /* 0-100V */


this is a bit unclear. the comment says 100V but your check is for 1000mV

Updated stale test cases from float to int32_t conversion

amiclaus · 2026-02-02T09:45:12Z

tests/drivers/power/max17616/test/support/test_max17616_support.c

+	}
+
+	if (telemetry->valid_mask & 0x08) { /* IOUT */
+		if (telemetry->iout_ma < 0 || telemetry->iout_ma > 1000) { /* 0-100A */


Updated stale test cases from float to int32_t conversion

amiclaus · 2026-02-02T09:45:24Z

tests/drivers/power/max17616/test/support/test_max17616_support.c

+	}
+
+	if (telemetry->valid_mask & 0x02) { /* VOUT */
+		if (telemetry->vout_mv < 0 || telemetry->vout_mv > 500) { /* 0-50V */


Updated stale test cases from float to int32_t conversion

amiclaus · 2026-02-02T09:46:17Z

drivers/power/max17616/iio_max17616.c

+	},
+	{
+		.name = "pout",
+		.ch_type = IIO_ALTVOLTAGE,


shouldn't this be IIO_POWER?

Corrected channel type for power

amiclaus · 2026-02-02T09:46:43Z

drivers/power/max17616/iio_max17616.c

+	struct max17616_iio_desc *iio_max17616 = (struct max17616_iio_desc *)device;
+	struct max17616_telemetry telemetry;
+	struct max17616_status status;
+	uint16_t raw_value;


unused variable.

Removed unused variable

cjones-adi · 2026-02-03T09:05:36Z

V13

Rebased to latest main
Addressed PR comments (Update overlooked float function return and unit test cases from float to int32_t conversion, add NULL check on max17616_read_status_byte(), align local variable type qualifiers for power calculation, add missing iio write attribute for nominal voltage and pgood threshold channels, etc.)

amiclaus

some comments on my side.

amiclaus · 2026-02-03T09:36:21Z

drivers/power/max17616/max17616.c

+int max17616_remove(struct max17616_dev *dev)
+{
+	int ret;
+


missing NULL check for dev.

the NULL dev is pre-checked by the calling function (a valid dev is a requirement to call this function)

amiclaus · 2026-02-03T09:37:48Z

drivers/power/max17616/max17616.c

+		if (ret)
+			return ret;
+
+		*value_milliunit = (int32_t)(((uint64_t)(uint32_t)vout_mv *


do we want here to cat to uint? was looking at max17616_read_telemetry_all which handles stuff with signed integers.

looking at the max17616_read_telemetry_all, the calculation there needs to follow the cast to uint for proper protection against overflow (resulting to large negative values) calculation. changed calculation in max17616_read_telemetry_all instead

amiclaus · 2026-02-03T09:38:33Z

drivers/power/max17616/max17616.c

+int max17616_verify_manufacturer_id(struct max17616_dev *dev)
+{
+	uint8_t mfr_id[8];
+	int ret;


missing NULL validation for dev throughout multiple functions.

the NULL dev is pre-checked in the init (which is the only function calling these static functions)

amiclaus · 2026-02-03T09:39:19Z

drivers/power/max17616/max17616.c

+#include <stdbool.h>
+#include <stdlib.h>
+#include <errno.h>
+#include <stdio.h>


#include <stdio.h> seems to be redundant.

true. thanks. removed #include <stdio.h>

amiclaus · 2026-02-03T09:40:30Z

drivers/power/max17616/max17616.c

+	memset(telemetry, 0, sizeof(struct max17616_telemetry));
+
+	ret = max17616_read_value(dev, MAX17616_VIN, &telemetry->vin_mv);
+	if (ret == 0)


if (!ret) for all occurences.

retained (ret == 0) for clarity. it indicates that the function seeks for success. it has become relatively important with the related comment on basic_example.c and corresponding changes

amiclaus · 2026-02-03T09:42:48Z

drivers/power/max17616/iio_max17616.c

+	int value;
+	int ret;
+
+	ret = sscanf(buf, "%d", &value);


no range validation for value?

great observation. thanks. added the validation of values range in the driver side so as not be repeated here or other application call (DRY principle).

amiclaus · 2026-02-03T09:46:22Z

drivers/power/max17616/iio_max17616.c

+ * @param priv - Private data identifying which global attribute to write
+ * @return Number of bytes written on success, negative error code otherwise
+ */
+STATIC int max17616_iio_write_global_attr(void *device, char *buf, uint32_t len,


should we return len in this function?

yes, i agree. let's follow the write convention call of returning len on a successful write operation and negative values for error.

amiclaus · 2026-02-03T09:46:47Z

drivers/power/max17616/max17616.c

+	if (byte_count != nbytes)
+		return -EMSGSIZE;
+
+	memcpy(data, &rxbuf[1], byte_count);


include string.h?

it unintentionally not flagged perhaps due to other headers including it but i've explicitly added string.h for correctness

amiclaus · 2026-02-03T09:48:41Z

projects/max17616/src/examples/basic/basic_example.c

+		/* Read telemetry */
+		ret = max17616_read_telemetry_all(max17616_dev, &telemetry);
+		if (ret)
+			pr_err("Failed to read telemetry: %d\n\r", ret);


we should somehow go to exit: for proper cleanup

looking at max17616_read_telemetry_all, it doesn't really return error worthy of discontinuing the loop. modified the max17616_read_telemetry_all to catch read operation errors so it would warrant an exit and clean up here. great observations. thanks.

amiclaus · 2026-02-03T09:49:25Z

drivers/power/max17616/max17616.h

+};
+
+enum max17616_status_byte {
+	MAX17616_STATUS_BIT_GENERAL,		// Not supported


let's be consistent with comments /* */

i agree. standardized comments.

cjones-adi · 2026-02-04T12:50:16Z

V14

Rebased to latest main
Addressed PR comments (double check missing and unused headers, improve max17616_read_telemetry_all, return len upon successful write to follow Linux's sys write convention, add validation of ranges for enum type parameters, etc.)

amiclaus

minor comments, otherwise lgtm.

amiclaus · 2026-02-06T13:52:18Z

drivers/power/max17616/max17616.c

+int max17616_send_byte(struct max17616_dev *dev, uint8_t cmd)
+{
+	uint8_t tx_buf[2] = {0};
+


dev null check missing.

Added dev null check

amiclaus · 2026-02-06T13:52:34Z

drivers/power/max17616/max17616.c

+	uint8_t rx_buf[2];
+	uint8_t tx_buf[2] = {0};
+	tx_buf[0] = cmd;
+


ditto: dev null check missing.

Added dev null check

amiclaus · 2026-02-06T13:53:29Z

drivers/power/max17616/max17616.c

+	int ret;
+
+	ret = no_os_i2c_remove(dev->i2c_desc);
+	if (ret)


nit: ignore error here.

Ignore error on i2c removal

Add header and source files for max17616 driver. Signed-off-by: Carlos Jones <carlosjr.jones@analog.com>

Signed-off-by: Carlos Jones <carlosjr.jones@analog.com>

Add README.rst documentation file for max17616 alongside other documentation related files. Signed-off-by: Carlos Jones <carlosjr.jones@analog.com>

Add project files for both basic and IIO examples for max17616. Signed-off-by: Carlos Jones <carlosjr.jones@analog.com>

Add README.rst documentation file for project alongside other documentation related files. Signed-off-by: Carlos Jones <carlosjr.jones@analog.com>

Add unit test files for the max17616 driver. Signed-off-by: Carlos Jones <carlosjr.jones@analog.com>

cjones-adi · 2026-02-06T15:00:13Z

V15

Rebased to latest main
Addressed PR comments (add dev null check on read byte and send byte, ignore error on i2c removal)

cjones-adi requested review from CiprianRegus, amiclaus, buha, danmois, dbogdan and rbolboac as code owners September 25, 2025 04:13

cjones-adi force-pushed the dev/max17616 branch from 5513eaa to 94940e7 Compare September 30, 2025 04:24

cjones-adi force-pushed the dev/max17616 branch from 3988f35 to a021cb3 Compare September 30, 2025 06:51

cjones-adi force-pushed the dev/max17616 branch from a021cb3 to 206c239 Compare October 1, 2025 02:32

cjones-adi force-pushed the dev/max17616 branch from 206c239 to cbda533 Compare October 1, 2025 04:11

cjones-adi force-pushed the dev/max17616 branch 2 times, most recently from b1687b3 to 39f0f5a Compare October 1, 2025 04:43

jemfgeronimo self-requested a review October 27, 2025 08:22

kseerp reviewed Oct 28, 2025

View reviewed changes

cjones-adi force-pushed the dev/max17616 branch from 02d0e3e to e409f37 Compare January 15, 2026 01:20

amiclaus reviewed Jan 20, 2026

View reviewed changes

cjones-adi force-pushed the dev/max17616 branch from e409f37 to f120728 Compare February 2, 2026 04:44

cjones-adi requested review from RaduSabau1, cristina-suteu, raezt, ralucabozdog, ranechita, rbudai98 and stefpopa as code owners February 2, 2026 04:44

cjones-adi force-pushed the dev/max17616 branch from f120728 to 709e096 Compare February 2, 2026 08:20

amiclaus reviewed Feb 2, 2026

View reviewed changes

cjones-adi force-pushed the dev/max17616 branch from 709e096 to 644b67f Compare February 3, 2026 02:20

amiclaus reviewed Feb 3, 2026

View reviewed changes

cjones-adi force-pushed the dev/max17616 branch from 644b67f to d1ebf91 Compare February 4, 2026 12:28

amiclaus reviewed Feb 6, 2026

View reviewed changes

cjones-adi added 6 commits February 6, 2026 22:40

drivers: power: max17616: Add driver support for max17616

ac454ce

Add header and source files for max17616 driver. Signed-off-by: Carlos Jones <carlosjr.jones@analog.com>

drivers: power: max17616: Add IIO support for MAX17616

9e8afa0

Signed-off-by: Carlos Jones <carlosjr.jones@analog.com>

drivers: power: max17616: Add README documentation for max17616

721b356

Add README.rst documentation file for max17616 alongside other documentation related files. Signed-off-by: Carlos Jones <carlosjr.jones@analog.com>

projects: max17616: Add project for max17616

14f87bd

Add project files for both basic and IIO examples for max17616. Signed-off-by: Carlos Jones <carlosjr.jones@analog.com>

projects: max17616: Add README documentation for project

2b696c5

Add README.rst documentation file for project alongside other documentation related files. Signed-off-by: Carlos Jones <carlosjr.jones@analog.com>

tests: drivers: power: max17616: Add unit tests for max17616

2a9af69

Add unit test files for the max17616 driver. Signed-off-by: Carlos Jones <carlosjr.jones@analog.com>

cjones-adi force-pushed the dev/max17616 branch from d1ebf91 to 2a9af69 Compare February 6, 2026 14:55

github-actions bot added drivers projects documentation labels Feb 6, 2026

Conversation

cjones-adi commented Sep 25, 2025

Pull Request Description

PR Type

PR Checklist

Uh oh!

CLAassistant commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

buha commented Sep 29, 2025

Uh oh!

azure-pipelines bot commented Sep 29, 2025

Uh oh!

kister-jimenez commented Sep 30, 2025

Uh oh!

azure-pipelines bot commented Sep 30, 2025

Uh oh!

cjones-adi commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kister-jimenez commented Sep 30, 2025

Uh oh!

azure-pipelines bot commented Sep 30, 2025

Uh oh!

cjones-adi commented Oct 1, 2025

Uh oh!

jemfgeronimo commented Oct 1, 2025

Uh oh!

azure-pipelines bot commented Oct 1, 2025

Uh oh!

cjones-adi commented Oct 1, 2025

Uh oh!

cjones-adi commented Oct 1, 2025

Uh oh!

azure-pipelines bot commented Oct 1, 2025

Uh oh!

kister-jimenez commented Oct 2, 2025

Uh oh!

azure-pipelines bot commented Oct 2, 2025

Uh oh!

kseerp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amiclaus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CLAassistant commented Sep 25, 2025 •

edited

Loading

cjones-adi commented Sep 30, 2025 •

edited

Loading

cjones-adi Feb 3, 2026 •

edited

Loading