Conversation
Test Results1 715 tests +1 462 ✅ ±0 12m 3s ⏱️ -1s Results for commit 4f448e2. ± Comparison against base commit b89168a. This pull request removes 4 and adds 5 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
c893d3b to
87f83be
Compare
tfcollins
reviewed
Sep 15, 2025
adi/ada4355.py
Outdated
| @property | ||
| def test_mode(self): | ||
| """Get test mode register value (0x0D)""" | ||
| return int(self.ada4355_register_read(0x0D), 0) # returns integer |
Collaborator
There was a problem hiding this comment.
Why is this not part of the driver? We rarely add register specific attributes as they point out deficiencies in the drivers. This returns are value as well, so how do we know what it means? If this doesn't get into the driver it needs to be at least documented what the return (and written) values can be
tfcollins
reviewed
Sep 15, 2025
Comment on lines
+82
to
+87
| class _channel(attribute): | ||
| """ ada4355 channel """ | ||
|
|
||
| def __init__(self, ctrl, channel_name): | ||
| self.name = channel_name | ||
| self._ctrl = ctrl |
Collaborator
There was a problem hiding this comment.
What is the purpose of this code?
87f83be to
aca9204
Compare
Add ada4355 pyadi-iio support for the linux driver. https://github.com/analogdevicesinc/linux/blob/34bb38377c9daa30d2abc632b82b4b654a32e90b/drivers/iio/adc/ada4355.c Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@analog.com>
aca9204 to
4f448e2
Compare
Collaborator
Author
|
V2:
|
|
Generated documentation for this PR is available at Link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ada4355 pyadi-iio support for the linux driver.
https://github.com/analogdevicesinc/linux/blob/34bb38377c9daa30d2abc632b82b4b654a32e90b/drivers/iio/adc/ada4355.c
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Documentation
If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.
Checklist: