Avoid throwing an exception on tracks without an explicitRating key#59
Open
palmer-dabbelt wants to merge 1 commit intoand3rson:masterfrom
Open
Avoid throwing an exception on tracks without an explicitRating key#59palmer-dabbelt wants to merge 1 commit intoand3rson:masterfrom
palmer-dabbelt wants to merge 1 commit intoand3rson:masterfrom
Conversation
Without this patch I get some responses from the server that lack an explicitRating key, causing an exception to be thrown that results in these tracks being dropped from the user interface. This simply checks to see if the explicitRating key exists before attempting to read it. Signed-off-by: Palmer Dabbelt <palmer@dabbelt.com>
palmer-dabbelt
force-pushed
the
explicit-rating
branch
from
ffea896 to
bfd2666
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this patch I get some responses from the server that lack an
explicitRating key, causing an exception to be thrown that results in
these tracks being dropped from the user interface. This simply checks
to see if the explicitRating key exists before attempting to read it.
Signed-off-by: Palmer Dabbelt palmer@dabbelt.com