Add mobile_client.get_top_songs() to "Liked Songs"#60
Open
palmer-dabbelt wants to merge 1 commit intoand3rson:masterfrom
Open
Add mobile_client.get_top_songs() to "Liked Songs"#60palmer-dabbelt wants to merge 1 commit intoand3rson:masterfrom
palmer-dabbelt wants to merge 1 commit intoand3rson:masterfrom
Conversation
The current list of liked songs is only populated with those that happen to have been enumerated, leaving out songs that have been marked as thumbs up but are not in the library or a playlist. This patch explicitly walks the list from "get_top_songs()", which contains some of the songs that have been marked as thumbs up. The result is that my liked songs list matches what is shown on my phone. See simon-weber/gmusicapi#637 for more information. Signed-off-by: Palmer Dabbelt <palmer@dabbelt.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current list of liked songs is only populated with those that happen
to have been enumerated, leaving out songs that have been marked as
thumbs up but are not in the library or a playlist. This patch
explicitly walks the list from "get_top_songs()", which contains some of
the songs that have been marked as thumbs up. The result is that my
liked songs list matches what is shown on my phone.
See simon-weber/gmusicapi#637 for more
information.
Signed-off-by: Palmer Dabbelt palmer@dabbelt.com