Skip to content

Forward srid to children of multitype container items #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Forward srid to children of multitype container items #38

wants to merge 2 commits into from

Conversation

georgeboot
Copy link

@georgeboot georgeboot commented Dec 4, 2024 •
edited
Loading

Currently, when decoding for example a MultiPolygon with SRID (EWKB), the MultiPolygon will have SRID filled in, but the nested Polygons, linestrings and points dont have it. This is incorrect.

This pull requests changes the we the inner types are read and fixes the issue.

@EvanCarroll
Copy link

This breaks three tests...

failures:
    ewkb::test_geometry_read
    ewkb::test_multiline_read
    ewkb::test_multipolygon_read

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgeboot @EvanCarroll