Fix: conftest fmts all files #5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with conftest-fmt where all files in the working directory are formatted regardless of if they are staged or committed to git. This is an undesirable behaviour for pre-commit as files should be passed to hooks by pre-commit rather than treating all files regardless.
In particular this causes an issue when the
PRE_COMMIT_HOMEenvironment variable is set to a path within the git repo (as per the gitlab CI example) as the hook tries to lint files within .cache directories.The current behaviour can be maintained if required by configuring the hook to run on all files in the working directory, but this is not the default behaviour of pre-commit and is not recommended - eg:
The conftest-validate hook has a similar issue and is also fixed by this PR.