Skip to content

Improve forge auto-detection and URL handling#202

Merged
piegamesde merged 3 commits intoandir:masterfrom
piegamesde:dev
Feb 12, 2026
Merged

Improve forge auto-detection and URL handling#202
piegamesde merged 3 commits intoandir:masterfrom
piegamesde:dev

Conversation

@piegamesde
Copy link
Collaborator

No description provided.

@piegamesde piegamesde force-pushed the dev branch 2 times, most recently from 397193a to 761de60 Compare February 11, 2026 18:03
Copy link
Collaborator

@Coca162 Coca162 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, some minor nits/questions

- Added a log message for the detected forge type, and debug log
messages to make it easier to figure out what is happening when
auto-detection fails
- When explicitly specifying a forge via `--forge`, auto-detection
failures are a hard error instead of falling back to generic git forges
It turns out that anyhow::Context is also implemented for options,
therefore we can use it directly without having to go through
`ok_or_else`
@piegamesde piegamesde merged commit 74ad332 into andir:master Feb 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants