fix(social-login): no password-expired on social login#623
Open
Gzerox wants to merge 1 commit intoandrechristikan:developmentfrom
Open
fix(social-login): no password-expired on social login#623Gzerox wants to merge 1 commit intoandrechristikan:developmentfrom
Gzerox wants to merge 1 commit intoandrechristikan:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user signs up via a social provider, we intentionally do not set
user.passwordExpired(for obvious reasons — no local password involved).However, in
UserGuard, during the call touserService.validateUserGuard, we currently run the following logic:The key problem is the call to:
this.authUtil.checkPasswordExpired(user.passwordExpired).In the social login case,
user.passwordExpiredis alwaysnull.This value is then passed to the following utility method:
Since the comparison is performed against a
nullvalue, the date check behaves incorrectly and results in users being blocked by the guard, even though password expiration should not apply to social-authenticated users.