Added zoomin and zoomout events#334
Draft
jhhend wants to merge 2 commits intoandreknieriem:masterfrom
Draft
Conversation
Collaborator
|
Hi @jhhend this looks like a great addition. Thanks for opening the PR. I think this is a good addition for the next major-ish release |
Author
This is great to hear. Let me know of any extra functionality or requirements this would need to meet the standards for release. I will be watching this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there,
We use simplelightbox and found that one of our clients wanted extra functionality added to the lightbox when the user zoomed in/out of an image. I achieved the functionality we needed via a MutationObserver, but thought that events which can be triggered on zoom would be quite helpful.
I understand that this is not comprehensive, since it does not cover pinch zooming or double tapping - I am open to hearing thoughts on how to make this more comprehensive, if needed, just opening this request for visibility.
Thanks so much for your commitment and dedication to maintaining this tool.