-
-
Couldn't load subscription status.
- Fork 114
Proposed Improvement: migrate from Poetry + requirements.txt to UV #3902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed Improvement: migrate from Poetry + requirements.txt to UV #3902
Conversation
|
Hi, thanks so much for tackling this. I've sort of muddled on but never really got time to look at this properly. It looks like a LOT of lint errors due to my scruffy code, think we'll need to add those to ignored for now. I am working on a V3 which is a very large change, which I'll merge in soon (life permitting) so I don't want to go changing the existing component code at the moment, I can gradually fix/remove those ignored once V3 is merged. Regarding other improvements it'd be great if you want to chip away at things, just don't touch the custom_component code folder for now and it should still be easy to merge. UPDATE |
|
I think commenting the ruff line makes sense for now. Is the intention to remove the ruff ignore lines from the pyprojegt.toml and I comment the validate step after v3? If so I think this should be good to go! |
|
After you publish v3 if you'd like me to tackle the ruff formatting on all the files just open an issue and assign me :) |
|
I will try and do the formatting as I merge in v3, it's not that difficult but I didn't want to do it twice. I'll go ahead and merge this one now and create some issues for the items you've discussed so they're not forgotten. Thanks again for the great work on this, it's so much cleaner than the mess that has evolved. |
# Conflicts: # poetry.lock # pyproject.toml
|
Hi again, sorry I've had real difficulty with UV & Dev Containers, which seems to be so new that few are doing it. |
|
I haven't messed with Dev containers before. Care to share the issues? I can try to look into it |
@andrew-codechimp I noticed you had a poetry.lock file, and an out of date pyproject.toml, but were also using requirements.txt
you were also already using uv in a workflow to install the requirements.txt
this PR updates:
pyproject.toml
dependabot
setup.sh
lint.yml
your json_librarian.yml can be updated to leverage uv and the pyproject.toml as well.. adding a new dependency group for the librarian needs would allow you to move away from the .github/scripts/library_doc/requirements.txt file. but I've left that alone for now