Added support for adding locally installed games to lutris#50
Open
HashimHS wants to merge 3 commits intoandrew-ld:masterfrom
Open
Added support for adding locally installed games to lutris#50HashimHS wants to merge 3 commits intoandrew-ld:masterfrom
HashimHS wants to merge 3 commits intoandrew-ld:masterfrom
Conversation
Owner
|
It would be better to have a generic component that acts as a file picker so it can be reused in other parts of the app. This would also make the AddGameDialog much smaller (in term of code). Additionally, this part should be handled by Node.js—the only part managed by lutris_wrapper.py should be the final addition to the library. |
AddGame component refactor
Author
|
I have separated the directory picker as a new component "Pathfinder.jsx". |
Author
|
The fields required for runners are fetched though the API. Lutris API is all python. Which parts would you like to be written in Nodejs? |
Owner
|
@HashimHS browse_path_main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added "Add game" to system menu. This option opens a window to add locally installed game to lutris. I have tested it by adding an rpcs3 game and launching it. Should work for all runners though.