Allow static methods on components #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please resolve conflicts and update your PR. |
|
Dang, I merged and resolved, but then tried to be good and squashed — and the conflict is back. You know of a way to fix it now other than submitting a fresh PR? |
|
I think submitting a new PR should be much easier than fixing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a static method (e.g.
fetchData) to fetch just the data required to render a component on the server is a standard practice for universal apps.renderProps: Objectas currently declared doesn't allow the static method, becauseObjectdoesn't have it on its own prototype. Declaring it asanywill fix this problem.