Simplify the Pool type#42
Merged
andrewMacmurray merged 9 commits intoandrewMacmurray:mainfrom Jul 15, 2025
Merged
Conversation
Owner
|
Nice, almost there. Can you update the Can you add a description to the PR with the rationale for the change too? (More or less what you wrote in the elm slack a while back). |
Contributor
Author
|
Done 👍 |
Owner
|
This is great, thanks for your work on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version of elm-concurrent-task requires the tasks to have uniform result/error types, as the types of
Task x aare reflected inPool msg x a.This PR changes the API such that we can get away with a simpler
Pool msg, which means that tasks can have any shape, and they just need to be converted to a uniformMsgwhenattempted. This makes it easier to use the library, especially in bigger projects