Simplify pool id internals, allow manual assignment#51
Merged
andrewMacmurray merged 2 commits intomainfrom Jan 2, 2026
Merged
Conversation
This was way too complicated internally - although it's a bit more management for the end user it feels like a fair tradeoff for internal complexity.
andrewMacmurray
force-pushed
the
simplify-pool-id
branch
from
77f7a53 to
beb4fac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pool ids allow multiple different
ConcurrentTask.pools to be connected to a single pair ofsendreceiveports. I tried hiding this from the consumer by automatically assigning pool ids from the js runner - however this added a lot of internal complexity.This change removes all that code and instead allows the consumer to manually add a pool id:
e.g. these can be used with the same port pair without messages interfering