Add analyzer to warn when enums are nested inside generic types#157
Closed
Add analyzer to warn when enums are nested inside generic types#157
Conversation
Copilot
AI
changed the title
[WIP] Handle enums that are nested inside generic types
Add analyzer to warn when enums are nested inside generic types
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new analyzer (diagnostic NEEG002) that detects when an enum decorated with
[EnumExtensions]is nested inside a generic parent type and generates a warning, since this scenario is not currently supported.Problem
Previously, the generator would attempt to generate extension methods for enums nested inside generic types, which would result in invalid code generation. For example:
Solution
The implementation adds:
EnumNestedInGenericType(NEEG002) with clear warning messageImplementation Details
EnumGenerationResultstruct to handle both success and diagnostic casesGetEnumGenerationResultmethod that checks the type hierarchy before attempting generationExecuteWithResultto handle diagnosticsVerification
The implementation correctly handles all scenarios:
Fixes #115.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.