Don't embed the attributes in the target dll#160
Merged
andrewlock merged 1 commit intomainfrom Jul 7, 2025
Merged
Conversation
af62dc5 to
3f77fa4
Compare
Test Results 144 files - 18 144 suites - 18 2m 18s ⏱️ -50s Results for commit 3f77fa4. ± Comparison against base commit 6ff64d1. This pull request removes 2090 tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stops making it possible to embed the
[EnumExtensions]attribute into the target dll by setting"NETESCAPADES_ENUMGENERATORS_EMBED_ATTRIBUTES". This is rarely the right thing to do, and we're already doing the work to ship the attribute in a dedicated dll. This also reduces some of the duplication, removes a config combination to need to test, and opens up the ability to ship "helper" types in the "attributes" dll